Delay singlecore gpu interrupts; Fixes Bomberman Jetters in single core mode. #10244
Conversation
phire
force-pushed
the
ban-timetravel
branch
from
a9d7cdd
to
263dd01
Compare
Fixes Bomberman Jetters in single core mode. When single core mode pauses the CPU to execute the GPU FIFO it greedily executes the whole thing. Before this commit, Finish and Token interrupts would happen instantly, not even taking into account how long the current FIFO window has taken to execute. The interrupts would be effectively backdated to the start of this execution window. This commit does two things: It pipes the current FIFO window execution time though to the interrupt scheduling and it enforces a minimum delay of 500 cycles before an interrupt will be fired.
phire
force-pushed
the
ban-timetravel
branch
from
263dd01
to
f5c550e
Compare
| // games time to setup any interrupt state | ||
| cycles = std::max(500, cycles_into_future); | ||
| } | ||
| CoreTiming::ScheduleEvent(cycles, et_SetTokenFinishOnMainThread, 0, from); |
There was a problem hiding this comment.
I'm noticing a pre-existing bug here, which I fear I'm making worse.
There is no synchronisation, so if there are many finish or tokens close to each other in the FIFO, they will stomp over each other. The cpu thread will only see a single interrupt, and the token will jump straight to the final value.
This can happen in dual-core mode, randomly if the gpu thread is fast, or the cpu thread is slow.
Before this PR, this can happen in single core mode, but only within a single FIFO window (or if multiple gather-pipe bursts happen within the same JIT block)
After this PR, this can also happen when multiple gather-pipe bursts happen to within 500 cycles of each other.
I fear that this bug needs be fixed before merging this fix, otherwise we risk causing more regressions.
|
Fixes Resident Evil 3 and Bomberman Jetters in Single Core. Fixes Advance Game Port and other Datel Loaders that use the same era loader. Requires MMU to be off. |
|
We're going to merge this to see if it breaks anything. |
Fixes Bomberman Jetters in single core mode.
When single core mode pauses the CPU to execute the GPU
FIFO it greedily executes the whole thing. Before this commit,
Finish and Token interrupts would happen instantly, not even
taking into account how long the current FIFO window has
taken to execute. The interrupts would be effectively backdated
to the start of this execution window.
This commit does two things: It pipes the current FIFO window
execution time though to the interrupt scheduling and it enforces
a minimum delay of 500 cycles before an interrupt will be fired.