Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes broken texture dumping.
PNG_FORMAT_RGBandPNG_COLOR_TYPE_RGBboth evaluate to 2, butPNG_FORMAT_RGBAevaluates to 3 whilePNG_COLOR_TYPE_RGBAevaluates to 6; the bit indicating a palette is 1 while the bit indicating alpha is 4.This generates an error, but because the default libpng error handler logs to stderr, it wasn't seen. I've also added custom error handlers that put it into Dolphin's logging system. With that, the following message now showed up (prior to fixing the above issue):