Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderbase: Show rerecord count #10256

Merged
merged 1 commit into from Dec 3, 2021

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Nov 30, 2021

This PR adds a "Show Rerecord Count" toggle under the Movie menu. When enabled, this causes the RenderBase to show s_rerecords in the Movie window.

Note that the rerecord count will show 0 if a movie is not being recorded or playing back. I'm curious if anyone has any thoughts about if this should be hidden? Perhaps check for if IsMovieActive()? Or perhaps if the rerecord count doesn't update, it's a healthy reminder to TASers that they aren't actively recording a movie (I sometimes accidentally forget to check if I am in read-only mode or not).

Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I think it's fine to keep it visible when a movie isn't active, though perhaps "Rerecords: N/A" would also work. Maybe the read-only status would also be useful to include in the movie window, though?

Simply shows Movie::s_rerecords in the ImGui Movie window
@malleoz
Copy link
Contributor Author

malleoz commented Dec 1, 2021

Code looks good to me. I think it's fine to keep it visible when a movie isn't active, though perhaps "Rerecords: N/A" would also work. Maybe the read-only status would also be useful to include in the movie window, though?

I've decided to check IsMovieActive() within Movie::GetRerecords() to show N/A if no movie is currently active. This should suffice for now. To show the status of read-only can be its own PR in the future I figure.

@phire phire merged commit 0327bc2 into dolphin-emu:master Dec 3, 2021
10 checks passed
@malleoz malleoz deleted the show-rerecord-count branch December 3, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants