JitArm64: Allocate 64 MB for farcode #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My change in 867cd99 caused farcode to fill up much more than before. Most games still ran fine, but certain games would have multiple cache clears per minute, on top of being overall slow. Maybe there's something prettier we can do about this than just allocating more RAM, but we have the resource budget for making Dolphin use more RAM, so I consider increasing the size of the cache to be a good solution at least for the time being. At least for Prince of Persia: The Forgotten Sands, 48 MB isn't enough to stop the cache clears, but 64 MB is. (I only played the game for a few minutes when testing, though.)
JosJuice
force-pushed
the
jitarm64-bigger-farcode
branch
from
a6b9c07
to
67787b5
Compare
|
Confirmed this PR Fixed slowndowns for me. Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
My change in 867cd99 caused farcode to fill up much more than before. Most games still ran fine, but certain games would have multiple cache clears per minute, on top of being overall slow.
Maybe there's something prettier we can do about this than just allocating more RAM, but we have the resource budget for making Dolphin use more RAM, so I consider increasing the size of the cache to be a good solution at least for the time being.
At least for Prince of Persia: The Forgotten Sands, 48 MB isn't enough to stop the cache clears, but 64 MB is. (I only played the game for a few minutes when testing, though.)