Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treewide: Adjust order of includes #10270

Merged
merged 7 commits into from Dec 12, 2021
Merged

Conversation

Pokechu22
Copy link
Contributor

@Pokechu22 Pokechu22 commented Dec 10, 2021

This PR adjusts includes in several files to match contributing.md's guidelines. The main thing that I was looking for was putting the header for the source file at the top of the list.

I also found and fixed several other minor issues, as doing this involved looking through all sources files in the project. Apart from the issues with dedicated commits, there are the following:

  • Video backends: the "main" file now includes the backend's VideoBackend.h file at the top (as that's effectively the header for the source file)
  • DXTexture.h and DXPipeline.h were missing an include for D3DBase.h, meaning they didn't work if they were included first.
  • ARM/x64-specific files include the common header (e.g. vertex loaders, CPUDetect)
  • Cases where multiple files are used to implement something declared in one header use that header (e.g. JIT/interpreter)
  • ENetUtil and DolphinFileDialog used file-relative includes before
  • EXI_DeviceIPL had an unused include of DVDInterface.h
  • EmuSubroutines included WiimoteReal.h when it only needed HW/Wiimote.h

@Pokechu22 Pokechu22 force-pushed the header-order branch 2 times, most recently from ee4333d to d623bd5 Compare December 10, 2021 02:50
@JosJuice JosJuice merged commit f4e2d36 into dolphin-emu:master Dec 12, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants