Merge CRC32.h into Hash.h and remove MD5.h #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
force-pushed
the
hash.h-merge
branch
from
84ddc67
to
df369de
Compare
lioncash
requested changes
Dec 10, 2021
Pokechu22
force-pushed
the
hash.h-merge
branch
from
df369de
to
b7973fe
Compare
Pokechu22
changed the title
JosJuice
reviewed
Dec 10, 2021
Pokechu22
force-pushed
the
hash.h-merge
branch
2 times, most recently
from
bceaddc
to
47f4730
Compare
iwubcode
reviewed
Dec 18, 2021
Pokechu22
force-pushed
the
hash.h-merge
branch
2 times, most recently
from
7099488
to
78e7e65
Compare
leoetlino
requested changes
Jan 1, 2022
This makes it easier to find the relevant functions.
Pokechu22
force-pushed
the
hash.h-merge
branch
from
78e7e65
to
56c087a
Compare
It uses DiscIO, and Common shouldn't depend on DiscIO. Instead, put this code in NetPlayClient.cpp.
Pokechu22
force-pushed
the
hash.h-merge
branch
from
56c087a
to
3d5b466
Compare
leoetlino
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The main point of this is to have one obvious location where all hash-related code is. I've also used the wrapper around zlib's
crc32in other places (it was first added for the GameCube IPL rom in 3d662e7).