New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FifoPlayer: Wait after clearing the screen #10273
FifoPlayer: Wait after clearing the screen #10273
Conversation
|
#10274 shows that this improves early memory updates (though early memory updates still isn't a good solution). So although this produces no visible fifoci differences, it is an improvement. |
641dec2
to
379add9
Compare
|
I ran some fifo logs and all of them ran as a black screen. Master shows them correctly. |
|
It seems like that happens with dual core (but not single core). However. fifoci uses dual core if I recall correctly, and it ran without issues so I'm not sure quite what's going on. |
The actual values don't matter since we overwrite all of the relevant fields, but other bits were not initialized (e.g. the top 12 bits of X10Y10), so the warning was semi-valid.
If we don't wait, then the copy will be performed at a later time, which may overwrite memory updates.
379add9
to
86f2b39
Compare
|
Fixed. I needed to add this to the fifoplayer's dolphin/Source/Core/Core/FifoPlayer/FifoPlayer.cpp Lines 217 to 219 in 86f2b39
(Also, I was incorrect in my thought that FifoCI uses dual core; I misinterpreted what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dual core and single core now work. Code changes make sense
Continues #10258. If we don't wait, then the copy will be performed at a later time, which may overwrite memory updates. This was causing problems for me when messing with memory updates, since the EFB copy would end up overwriting memory that had been written by the memory update. I think this may have been the cause of some of the differences in #10264, and will submit a second PR to check.