Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix opening system file manager #10276

Merged
merged 1 commit into from Dec 15, 2021

Conversation

JosJuice
Copy link
Member

Turns out that most phones ship with a special Google version of DocumentsUI instead of just using the AOSP version, despite the two being pretty similar as far as I can tell. This change makes us check for both package names instead of just the AOSP package name.

Turns out that most phones ship with a special Google version of
DocumentsUI instead of just using the AOSP version, despite the two
being pretty similar as far as I can tell. This change makes us
check for both package names instead of just the AOSP package name.
@ssdsnake
Copy link
Contributor

ssdsnake commented Dec 15, 2021

I'm happy to help test this, I don't recall how to get an APK but I have a ton of bored droids
I think Samsung has a special intent too for their file manager but I don't know that it's worth exploring if the Google/AOSP one opens up fine

Edit: Figured out how to get the APK 👍 Here's some initial checks. I'll try to find a Samsung.

Test Procedure: Install APK. Open File Activity by [Menu] => "Open File"

  • Pixel 5a / Stock Google / Android 11: Correctly opened com.google.android.documentsui file activity and allowed selection
  • OnePlus 8T / LineageOS 18.1 / Android 11: Correctly opened AOSP file activity and allowed selection
  • OnePlus 6T / LineageOS 17.1 / Android 10: Correctly opened AOSP file activity and allowed selection

@lioncash lioncash merged commit 66fc335 into dolphin-emu:master Dec 15, 2021
9 of 10 checks passed
@mbc07
Copy link
Contributor

mbc07 commented Dec 15, 2021

This PR fixes issue 12755...

@JosJuice
Copy link
Member Author

I think Samsung has a special intent too for their file manager but I don't know that it's worth exploring if the Google/AOSP one opens up fine

Unless the Samsung file manager supports accessing Android/data/ and there are phones where the Samsung file manager is installed but not easily for the user to access, there's no reason to add a button for it. Because this is the reason why we have a button for the Google file manager – on some phones this button is the only way to access Android/data/ without installing extra apps.

@JosJuice JosJuice deleted the android-fix-file-manager branch December 15, 2021 16:20
@mrdeathjr28
Copy link

hi in my case dont work, when try select game folder in file manager app crash maybe can be related with this:

https://bugs.dolphin-emu.org/issues/12764#change-743465

@JosJuice
Copy link
Member Author

I don't see how that could be related to this pull request (or to the issue report you linked for that matter). Please create a new issue report for it at https://bugs.dolphin-emu.org/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants