MemArena: Cleanup & interface changes for safer memory mapping. #10277
+299
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
reviewed
Dec 15, 2021
AdmiralCurtiss
force-pushed
the
memarena-cleanup
branch
from
56fcceb
to
bb9ae8e
Compare
Pokechu22
approved these changes
Dec 15, 2021
lioncash
reviewed
Dec 15, 2021
Source/Core/Common/MemArena.h
Outdated
| // CreateView() and ReleaseView(). This is used to make a mappable region for emulated memory. | ||
| // | ||
| // Parameters: | ||
| // - 'size' is the amount of bytes that should be allocated in this region. |
There was a problem hiding this comment.
You may want to turn these comments into doxygen style comments with /// or /** and use @param here
clang has a -Wdocumentation warning level that can flag anything if the parameter names change in the future through refactoring and the comment falls out of sync
There was a problem hiding this comment.
I matched it to the format used in BitUtils.h, I assume that's good?
AdmiralCurtiss
force-pushed
the
memarena-cleanup
branch
from
bb9ae8e
to
d9c2fa9
Compare
AdmiralCurtiss
force-pushed
the
memarena-cleanup
branch
from
d9c2fa9
to
1554128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See #9544 and #9834.
Note that there are no functional changes in this PR. (or should be, anyway)