LightingShaderGen: Make s_lighting_struct not inline #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Dec 18, 2021
| "\tfloat4 pos;\n" | ||
| "\tfloat4 dir;\n" | ||
| "};\n"; | ||
| static constexpr inline char s_lighting_struct[] = "struct Light {\n" |
There was a problem hiding this comment.
This can be simplified to:
Suggested change
| static constexpr inline char s_lighting_struct[] = "struct Light {\n" | |
| constexpr char s_lighting_struct[] = "struct Light {\n" |
and it should also resolve the warnings
There was a problem hiding this comment.
I guess that also means it won't be inlined into each object file... but that's a good thing; there's no reason for it to be duplicated 4 times for each uber/specialized vertex/pixel shader (especially since each one only uses it as out.Write("{}", s_lighting_struct);)
Pokechu22
force-pushed
the
static-lighting-struct-string
branch
from
bd48626
to
8a07636
Compare
Pokechu22
changed the title
Pokechu22
force-pushed
the
static-lighting-struct-string
branch
from
8a07636
to
d1651d6
Compare
This generated warnings on the freebsd builder.
Pokechu22
force-pushed
the
static-lighting-struct-string
branch
from
d1651d6
to
8502561
Compare
iwubcode
approved these changes
Dec 23, 2021
|
Someday soon we can make this a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This generated warnings on the freebsd builder (example).