GeomeryShaderGen: Set gl_ClipDistance on Vulkan as well as OpenGL #10286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes https://bugs.dolphin-emu.org/issues/12548.
Both Vulkan and OpenGL use
gl_ClipDistancewhen backend depth clamping is enabled. However, the geometry shader was only copying it for OpenGL, not for Vulkan. Since stereoscopic 3D uses a geometry shader, this was most visible there, but I suspect it could also affect line/point effects (I was unable to confirm this though).Here's the relevant vertex shader code (skipping the non-geomerty-shader path):
dolphin/Source/Core/VideoCommon/VertexShaderGen.cpp
Lines 561 to 568 in 6dae404
dolphin/Source/Core/VideoCommon/VertexShaderGen.cpp
Lines 582 to 599 in 6dae404