Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Port CPU overclock setting to new config. #10293

Merged
merged 3 commits into from Dec 27, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

Mostly so I can get a review on if this is the correct way to do it to avoid losing perf in hot code, in particular the config change callback.

Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation seems reasonable. But have we tested that there actually is any noticeable performance loss when doing this without the second commit?

Source/Core/Core/CoreTiming.cpp Show resolved Hide resolved
@AdmiralCurtiss
Copy link
Contributor Author

re perf, as always this is very unscientific but idling in the Melee main menu I get roughly:

before: ~390 FPS
without last commit: ~370 FPS
with last commit: ~390 FPS

@JosJuice
Copy link
Member

Alright, it definitely sounds like we should go with the caching then, considering it's a fairly simple thing to add.

@JMC47 JMC47 merged commit 6641157 into dolphin-emu:master Dec 27, 2021
10 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the config-port-cpu-overclock branch December 27, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants