Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameSettings: Patches for black screen effect for remaining versions of Pokémon Battle Revolution. #10297

Merged

Conversation

AdmiralCurtiss
Copy link
Contributor

See 254f39c / https://bugs.dolphin-emu.org/issues/12629.

(Fun fact: The Japanese version of PBR does not support widescreen!)

@JMC47
Copy link
Contributor

JMC47 commented Dec 27, 2021

I got the addresses from Revision 0 and Revision 2

Revision 2

80234580 39080000
80234588 38030000

Revision 0

802342dc 39080000
802342e4 38030000

Revision 2 appears to match Revision 1, where as Revision 0 is different.

@AdmiralCurtiss
Copy link
Contributor Author

I'll trust you on that.

Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (though obviously untested). You'll want to edit the PR title though since that's the message that gets used in the merge commit.

@AdmiralCurtiss AdmiralCurtiss changed the title GameSettings: Patches for black screen effect for EU & JP Rev 1 versions of Pokémon Battle Revolution. GameSettings: Patches for black screen effect for remaining versions of Pokémon Battle Revolution. Dec 27, 2021
@leoetlino leoetlino merged commit 8dd803b into dolphin-emu:master Jan 1, 2022
10 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the pbr-screen-border-patches branch January 1, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants