Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB Stub: add support for various query packets #10299

Merged
merged 1 commit into from Dec 30, 2021

Conversation

aldelaro5
Copy link
Member

These tends to get requested from either pure GDB or Ghidra. They reduce the verbosity of the communications. The QSupported packet is also important to implement for future proofing too.

Source/Core/Core/PowerPC/GDBStub.cpp Show resolved Hide resolved
Source/Core/Core/PowerPC/GDBStub.cpp Outdated Show resolved Hide resolved
Source/Core/Core/PowerPC/GDBStub.cpp Outdated Show resolved Hide resolved
Source/Core/Core/PowerPC/GDBStub.cpp Outdated Show resolved Hide resolved
Source/Core/Core/PowerPC/GDBStub.cpp Outdated Show resolved Hide resolved
Source/Core/Core/PowerPC/GDBStub.cpp Outdated Show resolved Hide resolved
These tends to get requested from either pure GDB or Ghidra. They reduce the verbosity of the communications. The QSupported packet is also important to implemnent for future proofing too.
Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here, but I haven't done any testing.

@JMC47 JMC47 merged commit 01f1802 into dolphin-emu:master Dec 30, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants