Pass 1, not false to MixAUXSamples as the aux ID in UCode_AX.cpp. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,7 +208,7 @@ void CUCode_AX::HandleCommandList() | |||
| case CMD_MIX_AUXB_NOWRITE: | |||
| addr_hi = m_cmdlist[curr_idx++]; | |||
| addr_lo = m_cmdlist[curr_idx++]; | |||
| MixAUXSamples(false, 0, HILO_TO_32(addr)); | |||
| MixAUXSamples(0, 0, HILO_TO_32(addr)); | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…OWRITE should have 1 being passed, not false, as the aux ID in MixAUXSamples.
delroth
added a commit
that referenced
this pull request
Feb 23, 2014
Pass 1, not false to MixAUXSamples' case "CMD_MIX_AUXB_NOWRITE" as the aux ID in UCode_AX.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
An AUX ID of 1 means to use AUX B, however in the previous case, we'd be using AUX A (id of 0). Considering the case is "CMD_MIX_AUXB_NOWRITE" we don't want this.