Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBA: Fix TAP detection #10301

Merged
merged 1 commit into from Jan 1, 2022
Merged

BBA: Fix TAP detection #10301

merged 1 commit into from Jan 1, 2022

Conversation

RA-Kooi
Copy link
Contributor

@RA-Kooi RA-Kooi commented Dec 27, 2021

Current code expects the component ID of the tap adapter to be equal to tap0901, however on my machine (Windows 10, latest TAP adapter) the component ID is root\tap0901. This should be a fix that is backwards compatible with "old"(?) setups.

Warepire
Warepire reviewed Dec 27, 2021
View reviewed changes
Copy link

@Warepire Warepire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic wise this looks fine to me, some minor comments.

Source/Core/Core/HW/EXI/BBA/TAP_Win32.cpp Outdated Show resolved Hide resolved
Source/Core/Core/HW/EXI/BBA/TAP_Win32.cpp Outdated Show resolved Hide resolved
@RA-Kooi
Copy link
Contributor Author

RA-Kooi commented Dec 27, 2021

I fixed all comments.

@leoetlino leoetlino merged commit 379ab16 into dolphin-emu:master Jan 1, 2022
10 checks passed
@RA-Kooi RA-Kooi deleted the BBAFix branch January 1, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Warepire Warepire Warepire left review comments

@Pokechu22 Pokechu22 Pokechu22 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@RA-Kooi @Warepire @Pokechu22 @leoetlino