DolphinQt: Fix generation of /external:I flags #10302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly concerns to building with Ninja, as that's what I tested it with. Originally it would only prepend the first path with `/external:I`, however all paths in the list have to be prepended with `/external:I`. The MS documentation seems to support this, as it makes no mention of it accepting a list. This is probably the worst way to implement this, I am unfamiliar with CMake.
iwubcode
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Mainly concerns to building with Ninja, as that's what I tested it with.
Originally it would only prepend the first path with
/external:I, however all paths in the list have to be prepended with/external:I.The MS documentation seems to support this, as it makes no mention of it accepting a list.
This is probably the worst way to implement this, I am unfamiliar with CMake.
As such you probably don't want to merge this, but I'll push it as a reminder for whoever is going to work on CMake support for Windows.