Config: Port FifoPlayer setting to new config system. #10305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
approved these changes
Dec 27, 2021
Pokechu22
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
LGTM.
It'd be nice to get this setting exposed on the UI somewhere (I occasionally use it with dump frames or the software renderer's dump objects function, where looping endlessly leads to an excessive amount of files; this was particularly relevant for debugging issues with the first frame of FIFO playback, though those are mostly solved now). That's something I could handle in a separate PR, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A quick and simple one.