Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Port AutoUpdate settings to new config system. #10307

Merged
merged 1 commit into from Dec 30, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

I took the opportunity to do pass some data to AutoUpdateChecker::CheckForUpdate() so we don't have to do the weird set-call-revert thing in InstallUpdateManually().

@AdmiralCurtiss
Copy link
Contributor Author

(Also this is untested because I have no idea how to test this...)

@JMC47 JMC47 merged commit 1112b2a into dolphin-emu:master Dec 30, 2021
10 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the config-port-autoupdate branch December 30, 2021 19:15
@SupervisedThinking
Copy link

Well this PR leads to instant segfaults for my dolphin build 🤔 while de91afaff31df5a8075527196aa1de84bc133bc3 works fine

Reading symbols from ./dolphin-emu...
(gdb) run
Starting program: /storage/dolphin-emu 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x00007f73f8b6570b in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /usr/lib/libstdc++.so.6
(gdb) backtrace full
#0  0x00007f73f8b6570b in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /usr/lib/libstdc++.so.6
No symbol table info available.
#1  0x0000000000565d80 in Config::Info<std::string>::Info (this=0xd63ce0 <Config::MAIN_AUTOUPDATE_UPDATE_TRACK>, location=..., default_value=...)
    at /build/LibreELEC-RR/build.LibreELEC-x11.x86_64-11.0-devel/build/dolphin-1112b2a19e3421cb90364769754570c44f81d1ab/Source/Core/Common/Config/ConfigInfo.h:47
No locals.
#2  0x000000000044b668 in __static_initialization_and_destruction_0 (__priority=65535, __initialize_p=1)
    at /build/LibreELEC-RR/build.LibreELEC-x11.x86_64-11.0-devel/toolchain/x86_64-libreelec-linux-gnu/include/c++/10.3.0/ext/new_allocator.h:79
No locals.
#3  0x000000000099aaf5 in __libc_csu_init (argc=argc@entry=1, argv=argv@entry=0x7ffd30a02ff8, envp=0x7ffd30a03008) at elf-init.c:89
        i = 12
        size = 169
#4  0x00007f73f87afd7a in __libc_start_main (main=0x443e93 <main(int, char**)>, argc=1, argv=0x7ffd30a02ff8, init=0x99aab0 <__libc_csu_init>, fini=<optimized out>, 
    rtld_fini=<optimized out>, stack_end=0x7ffd30a02fe8) at ../csu/libc-start.c:270
        result = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140136177575232, 140136175966240, 140136177575232, 140136066865673, 140136177392280, 1, 140725419257848, 
                140725419257864}, mask_was_saved = -15541600}}, priv = {pad = {0x7f73ff16e15e <call_init+158>, 0x0, 0x1, 0x7ffd30a02ff8}, data = {
              prev = 0x7f73ff16e15e <call_init+158>, cleanup = 0x0, canceltype = 1}}}
        not_first_call = <optimized out>
#5  0x000000000045d7fa in _start () at ../sysdeps/x86_64/start.S:120
No locals.

@leoetlino
Copy link
Member

#10370 should fix that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants