GDB Stub: validate the address exists before reading/writting to it #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Jan 1, 2022
aldelaro5
force-pushed
the
gdb-stub-fix-unkown-pointer
branch
from
97e92b0
to
80df730
Compare
aldelaro5
force-pushed
the
gdb-stub-fix-unkown-pointer
branch
from
80df730
to
bfa675c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This prevented unknown pointer spams when you connect with ghidra because it seems to want to probe memory that happened to be invalid, this shouldn't happen, we should just return an error and not panic.