Gdb stub: fix watchpoints #10309
Merged
Gdb stub: fix watchpoints #10309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Jan 1, 2022
aldelaro5
force-pushed
the
gdb-stub-fix-watchpoints
branch
from
c132638
to
b3eb33b
Compare
Fix dolphin erroring out on requests to remove access watchpoints.
Read only and Write only were reversed, now they are properly defined.
aldelaro5
force-pushed
the
gdb-stub-fix-watchpoints
branch
from
b3eb33b
to
9c784ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes 2 issues with watchpoints:
1: z4 packets would get ignored because of a bogus check for bogus types
2: read only watchpoint and write only watchpoint were reversed in the enum