VulkanContext: Ensure present queue family is valid before incrementing queueCreateInfoCount #10320
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
VulkanContext::CreateDevice()attempts to find appropriate graphics queue and present queue families. It will skip trying to find a present queue family if the surface isVK_NULL_HANDLE(headless mode). However, even if the present queue family isn't valid,queueCreateInfoCountwill be set to2as long as the graphics queue family index isn't the same as the present queue family index (which it won't, as the default value is the number of queues).This causes DolphinNoGUI in headless mode on macOS to crash, as MoltenVK would attempt to create an
MVKQueueusing an invalid configuration.