Config: Port Movie settings to new config system. #10323

AdmiralCurtiss · 2021-12-30T19:18:31Z

No description provided.

AdmiralCurtiss · 2021-12-30T19:19:18Z

Source/Core/VideoCommon/RenderBase.cpp

@@ -1670,7 +1672,7 @@ void Renderer::FrameDumpThreadFunc()

        // Stop frame dumping if we fail to start.
        if (!frame_dump_started)
-          SConfig::GetInstance().m_DumpFrames = false;
+          Config::SetCurrent(Config::MAIN_MOVIE_DUMP_FRAMES, false);


This one I wasn't sure whether I should be using SetBase(), SetCurrent(), or SetBaseOrCurrent(). Probably doesn't matter too much though.

The behavior in master where it effectively sets the base layer is actually really confusing, because the checkbox in the GUI doesn't update until you restart Dolphin, and so if you want to restart emulation and retry dumping, you have to realize that you have to go and turn the framedumping checkbox off and then on again even though it looks like it's already on. So I agree that SetCurrent makes sense.

Config: Port Movie settings to new config system.

aa437d9

AdmiralCurtiss commented Dec 30, 2021

View reviewed changes

JosJuice approved these changes Dec 30, 2021

View reviewed changes

JMC47 merged commit 5331160 into dolphin-emu:master Dec 30, 2021
10 checks passed

AdmiralCurtiss deleted the config-port-movie branch December 30, 2021 20:49

Config: Port Movie settings to new config system. #10323

Config: Port Movie settings to new config system. #10323

AdmiralCurtiss commented Dec 30, 2021

AdmiralCurtiss Dec 30, 2021

JosJuice Dec 30, 2021

Config: Port Movie settings to new config system. #10323

Config: Port Movie settings to new config system. #10323

Conversation

AdmiralCurtiss commented Dec 30, 2021

AdmiralCurtiss Dec 30, 2021

Choose a reason for hiding this comment

JosJuice Dec 30, 2021

Choose a reason for hiding this comment