Config: Port Debug settings to new config system. #10325
Merged
+119
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
commented
Dec 30, 2021
| const Info<bool> MAIN_DEBUG_JIT_LOAD_STORE_LXZ_OFF{{System::Main, "Debug", "JitLoadStorelXzOff"}, | ||
| false}; | ||
| const Info<bool> MAIN_DEBUG_JIT_LOAD_STORE_LWZ_OFF{{System::Main, "Debug", "JitLoadStorelwzOff"}, | ||
| false}; | ||
| const Info<bool> MAIN_DEBUG_JIT_LOAD_STORE_LBZX_OFF{{System::Main, "Debug", "JitLoadStorelbzxOff"}, | ||
| false}; |
There was a problem hiding this comment.
Note these were previously not stored to the INI, so I made up new config keys for them.
There was a problem hiding this comment.
These actually fully match the keys in the previous PR that attempted to do this: #9001
I'm happy with these keys.
AdmiralCurtiss
force-pushed
the
config-port-debug
branch
from
9430091
to
810dcfa
Compare
JosJuice
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've cached these in
JitBase(seeJitBase::RefreshConfig()) because that seemed like the easier approach -- otherwise I'd have to touch every single instruction codegen function. Likely better performance-wise too, though I haven't actually tested it.