Config: Port BluetoothPassthrough settings to new config system. #10326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
commented
Dec 30, 2021
| @@ -556,7 +558,7 @@ void BluetoothRealDevice::SaveLinkKeys() | |||
| std::string config_string = oss.str(); | |||
| if (!config_string.empty()) | |||
| config_string.pop_back(); | |||
| SConfig::GetInstance().m_bt_passthrough_link_keys = config_string; | |||
| Config::SetBase(Config::MAIN_BLUETOOTHPASSTHROUGH_LINK_KEYS, config_string); | |||
There was a problem hiding this comment.
Is SetBase() fine here or should this be SetBaseOrCurrent()? I can't really imagine a case where this is overridden by anything, but...
There was a problem hiding this comment.
SetBase sounds fine to me. We always want this to be persisted.
AdmiralCurtiss
force-pushed
the
config-port-bluetooth
branch
from
98413b1
to
111a2b8
Compare
leoetlino
reviewed
Dec 30, 2021
| @@ -556,7 +558,7 @@ void BluetoothRealDevice::SaveLinkKeys() | |||
| std::string config_string = oss.str(); | |||
| if (!config_string.empty()) | |||
| config_string.pop_back(); | |||
| SConfig::GetInstance().m_bt_passthrough_link_keys = config_string; | |||
| Config::SetBase(Config::MAIN_BLUETOOTHPASSTHROUGH_LINK_KEYS, config_string); | |||
There was a problem hiding this comment.
SetBase sounds fine to me. We always want this to be persisted.
AdmiralCurtiss
force-pushed
the
config-port-bluetooth
branch
from
111a2b8
to
478504f
Compare
leoetlino
approved these changes
Dec 30, 2021
AdmiralCurtiss
force-pushed
the
config-port-bluetooth
branch
from
478504f
to
5268878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This one is untested because I don't have a bluetooth adapter handy at the moment. Someone should test if it still works as expected.