GDB Stub: add support for lldb's qHostInfo #10330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
requested changes
Jan 1, 2022
aldelaro5
force-pushed
the
gdb-stub-add-hostinfo
branch
from
4ccc865
to
4033aad
Compare
|
This needs a rebase fwiw. |
aldelaro5
force-pushed
the
gdb-stub-add-hostinfo
branch
from
4033aad
to
7b4a5a1
Compare
aldelaro5
force-pushed
the
gdb-stub-add-hostinfo
branch
from
7b4a5a1
to
d705a5f
Compare
leoetlino
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This along with #10319 is actually all it takes to make lldb work correctly and it's very easy to implement so might as well add it.
NOTE: this is specific to lldb, more info here: https://github.com/llvm/llvm-project/blob/main/lldb/docs/lldb-gdb-remote.txt#L867
In my test though, it seems to mix up the packets with read memory, but I have a suspicion that it's an unrelated issue that I will be trying to address because from dolphin's side, it is replying correctly.