Config: Port remaining General settings to new config system. #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
commented
Jan 1, 2022
| { | ||
| Config::Info<std::string> iso_path{ | ||
| {Config::System::Main, "General", fmt::format("ISOPath{}", i)}, ""}; | ||
| Config::SetBase(iso_path, ""); // TODO: This actually needs a Config::Erase(). |
There was a problem hiding this comment.
We don't seem to have a way to actually remove a key from the new config system, so I've left this like this for now.
There was a problem hiding this comment.
You could call DeleteKey() on the relevant layer but yeah I think this is fine for now.
|
Also note: |
leoetlino
reviewed
Jan 1, 2022
| { | ||
| Config::Info<std::string> iso_path{ | ||
| {Config::System::Main, "General", fmt::format("ISOPath{}", i)}, ""}; | ||
| Config::SetBase(iso_path, ""); // TODO: This actually needs a Config::Erase(). |
There was a problem hiding this comment.
You could call DeleteKey() on the relevant layer but yeah I think this is fine for now.
AdmiralCurtiss
force-pushed
the
config-port-general
branch
from
814211a
to
d590aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.