Config: Port remaining Core settings to new config system (partial). #10340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiralCurtiss
force-pushed
the
config-port-core-1
branch
from
00194a5
to
fe2fccd
Compare
JosJuice
reviewed
Jan 4, 2022
|
LGTM other than the comment. |
AdmiralCurtiss
force-pushed
the
config-port-core-1
branch
from
fe2fccd
to
e08171f
Compare
JosJuice
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This isn't all of the settings yet (because there's quite a few), but I'm stopping for today and figured I could get these reviewed for now. This can be merged as-is, or I can push the rest into this PR too once I do them, doesn't really matter to me.