VideoCommon: Fix shader precompilization detection #10346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling of shaders, we can create bugs if there are issues. Android is assumed buggy
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
So this is disable on android only? |
Correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR #9414 assumed everything was buggy then tried to retroactively fix certain vendors. Unfortunately, this logic doesn't work. This led to windows and macos always using a single thread for shader compilation when opengl/vulkan were in use. Instead of attempting to fix this (which seemed like was not the intention of the bug database and also might have ill effects on other bugs), I decided to let everything support the detection by default. We can add bugs if something is broken because of it.
I say "all" but out of our fear with Android often being buggy, I marked that as our first OS that doesn't support the auto detection. Users wishing to speed-up precompilation can still manually set the threads in configuration like normal.