Config: Port remaining Core settings to new config system (part 2). #10349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
Jan 6, 2022
|
|
||
| const bool sd_card_inserted = Config::Get(Config::MAIN_WII_SD_CARD); | ||
| if ((sd_card_inserted && m_event->type == EVENT_INSERT) || | ||
| (!sd_card_inserted && m_event->type == EVENT_REMOVE)) |
There was a problem hiding this comment.
It would be cool if we could make this code use callbacks to detect the SD card being inserted/ejected instead of needing to manually call this EventNotify function. In particular, it would make it possible to insert/eject SD cards during emulation on Android. But we can save that for another PR.
AdmiralCurtiss
force-pushed
the
config-port-core-2
branch
from
769c7f9
to
eb5bb29
Compare
JosJuice
approved these changes
Jan 6, 2022
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The next one of these.