New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Port EXI device and SI device settings to new config system. #10354
Config: Port EXI device and SI device settings to new config system. #10354
Conversation
6b6ecca
to
9c2e5cb
Compare
|
I would be fine with this new PadType behavior. |
9c2e5cb
to
a8f95f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of casting going on in this PR. Is there any particular reason why the settings are defined as ints instead of the relevant enum type?
a8f95f8
to
1165082
Compare
1165082
to
5c325ee
Compare
|
I was somehow under the impression that you couldn't forward-declare an old C-style enum, but nope, seems to work fine. I've updated the settings to use the enum directly and removed the casts. |
|
For the record, forward declaring an enum is fine as long as you specify the underlying type (which is only possible starting from C++11). Forward declaring an enum class without specifying the underlying type is okay too (int is the default). |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Separate PR here because of this snippet of code that I'm not sure how to translate correctly into the new system:
This happens while parsing GameINIs and basically means 'if
PadTypeNis set to a valid value, overrideSIDeviceNwith that, otherwise keep the value set bySIDeviceN'. I can and have added these toGetINIToLocationMap(), but that's not quite the same behavior -- if you set it to an invalid value, Dolphin will now useSIDEVICE_NONErather than the currentSIDeviceNvalue. Are we fine with this? If not, how do we adjust the code so that previous behavior still applies?