Config: Port remaining Core settings to new config system (the rest). #10356
+116
−157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Depends on #10354.
I've put the Dual Core and MMU flags into the
Core::Systemclass, because they're accessed from quite a few locations, need to be fast to access, and can never change at game runtime anyway. If someone can think of a better place or solution, be my guest, but I think this works.After this the only config read/write code not directly in the new config system is the remaining few GameINI and Netplay initialization things in
BootManager.cpp. There's also a few settings left in the old config system that, apparently, never had a corresponding INI key and thus never persisted across sessions -- we probably need to decide on a case-by-case basis what we want to do with those. Same goes for the running game metadata that's stored in there. But hey, almost done now!