Android: remove save icon and add up button #10358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you call this an up button instead of a back button? Back and up are not the same thing. |
Simonx22
force-pushed
the
android-back-button
branch
2 times, most recently
from
516353d
to
b2cd25b
Compare
Simonx22
changed the title
JosJuice
reviewed
Jan 7, 2022
JosJuice
approved these changes
Jan 7, 2022
Simonx22
force-pushed
the
android-back-button
branch
from
b2cd25b
to
3cd6044
Compare
Simonx22
force-pushed
the
android-back-button
branch
from
3cd6044
to
0a82bb5
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR removes the save icon since it's no longer necessary. I've also added an up button to the top left of the screen in the settings and cheats view, which makes navigating feel much more natural.
Screenshots: