Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some contributing doc links #10359

Merged
merged 1 commit into from Jan 9, 2022
Merged

Update some contributing doc links #10359

merged 1 commit into from Jan 9, 2022

Conversation

PEmu2
Copy link
Contributor

@PEmu2 PEmu2 commented Jan 8, 2022

No description provided.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • burnout2-vehicletextures on mvk-osx-m1: diff
  • DKCR-Char on mvk-osx-m1: diff
  • DKCR-fast-depth on mvk-osx-m1: diff
  • ea-pink on mvk-osx-m1: diff
  • ssbb-mod-lloyd on mvk-osx-m1: diff

automated-fifoci-reporter

Pokechu22
Pokechu22 approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that the FifoCI differences are not caused by this PR, but are instead a nondeterminism issue with the moltenvk FifoCI instance that is causing false positives (it's being fixed).

@Pokechu22 Pokechu22 merged commit 36d6057 into dolphin-emu:master Jan 9, 2022
10 checks passed
@PEmu2 PEmu2 deleted the links branch January 10, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@PEmu2 @dolphin-emu-bot @Pokechu22