Create enum classes for EXI devices and slots

[Pokechu22]

This is something I started on a while back while working on redoing both the gamecube boot process (related to the broken AD16 implementation) and implementing support for SD geckos/the official SD adapter/SD2SP2; I haven't finished either of those, but this is a source of merge conflicts as well as a general improvement, so I might as well PR it. This PR is refactoring with no expected behavior differences, but I haven't done extensive testing on it.

[Warepire]

Can't you fold this like on line 61? And then the entire if block collapses into if Not IsUsingMemcard, set None, otherwise use the configured value? Or did I miss something here, logically?

[Pokechu22]

I'm not sure. I think the purpose here is to force it to be a memory card (and theoretically directly using the configured value could result in something other than a memory card); the Movie/TAS code only supports indicating whether a memory card is in use, and doesn't support other devices. But if we're overriding settings for movie purposes, why bother supporting both raw memory cards and memory card folders? Someone more experienced with the movie functions would have to chime in here.

To be clear, I'm assuming you're suggesting something like this:

void AddMemoryCards(Slot slot)
{
  EXIDeviceType memorycard_device;
  if (Movie::IsPlayingInput() && Movie::IsConfigSaved())
  {
    if (Movie::IsUsingMemcard(slot))
      memorycard_device = Config::Get(Config::GetInfoForEXIDevice(slot));
      // or:
      // memorycard_device = EXIDeviceType::MemoryCard;
    else
      memorycard_device = EXIDeviceType::None;
  }
  else
  {
    memorycard_device = Config::Get(Config::GetInfoForEXIDevice(slot));
  }

  g_Channels[SlotToEXIChannel(slot)]->AddDevice(memorycard_device, SlotToEXIDevice(slot));
}

[Pokechu22]

Looking at it further, I think the best approach would be to get rid of AddMemoryCards entirely and then handle this in MovieConfigLoader which is injected into the config system (CC @AdmiralCurtiss). That wasn't possible until recently when the EXI and other settings were moved to the new config system.

JosJuice says that there is a benefit to supporting both raw memory cards and memory card folders, since users need to manually supply the save file (it's not included in the move file). On the other hand, devices other than memory cards aren't supported and won't sync at all (at least for things like the microphone). So forcing it to be a memory card works, but I've changed it to instead stick with the user-specified device and generate a panic alert if an invalid device is selected.

[AdmiralCurtiss]

Yes, I would agree, handling this via LoadFromDTM() in MovieConfigLoader.cpp is likely the best approach here.

[Warepire]

What happens if slot for some reason is out of range? Or is slot always valid here?

[Pokechu22]

SlotToEXIChannel and SlotToEXIDevice will trigger a PanicAlertFmt if slot is invalid and return 0. Those functions will always return something within the valid device and channel ranges.

[AdmiralCurtiss]

Largely untested (I booted up a game and switched memory cards, and that worked, but not more than that) but code looks good to me now.

[BhaaLseN]

Code LGTM, untested.

[Dentomologist]

This is a preexisting issue but would it make sense to move the loop inside AddMemoryCards? The function is only called from here, and as it stands it adds a single device despite the name implying otherwise.

[Pokechu22]

I think that somewhat makes sense, but I'd rather rip out the entirety of AddMemoryCards and replace it with the new config system in a separate PR. I can rename the function to AddMemoryCard pretty easily though.

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• DKCR-fast-depth on mvk-osx-m1: diff
• ea-pink on mvk-osx-m1: diff
• rs2-skybox on mvk-osx-m1: diff
• rs3-bumpmapping on mvk-osx-m1: diff

_{^{automated-fifoci-reporter}}