Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Add missing legacy game INI mappings #10365

Merged
merged 2 commits into from Jan 12, 2022

Conversation

JosJuice
Copy link
Member

The "DSP" and "Controls" section names were both supported by BootManager.cpp before the recent mass-porting of settings. For backwards compatibility, we should keep supporting them.

Should fix https://bugs.dolphin-emu.org/issues/12792

The "DSP" game INI section name was supported by BootManager.cpp
before the section was ported to the new config system.
For backwards compatibility, we should keep supporting it.

Should fix https://bugs.dolphin-emu.org/issues/12792
This matches BootManager.cpp's old behavior.

Note: The other settings of the "Controls" section (WiimoteSource
and WiimoteSourceBB) are still handled in BootManager.cpp.
@JosJuice JosJuice changed the title Config: Add missing sections to GetINIToSectionMap Config: Add missing legacy game INI mappings Jan 11, 2022
@AdmiralCurtiss
Copy link
Contributor

Can confirm that this fixes https://bugs.dolphin-emu.org/issues/12792

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • DKCR-Char on mvk-osx-m1: diff
  • DKCR-fast-depth on mvk-osx-m1: diff
  • ea-pink on mvk-osx-m1: diff
  • metroid-visor on mvk-osx-m1: diff
  • mp3-bloom on mvk-osx-m1: diff
  • nhl-slap on mvk-osx-m1: diff
  • rs2-glass on mvk-osx-m1: diff
  • rs2-skybox on mvk-osx-m1: diff
  • rs3-bumpmapping on mvk-osx-m1: diff
  • spyro-bloom on mvk-osx-m1: diff
  • ssbb-mod-lloyd on mvk-osx-m1: diff

automated-fifoci-reporter

@JMC47 JMC47 merged commit ca96421 into dolphin-emu:master Jan 12, 2022
10 checks passed
@JosJuice JosJuice deleted the missing-ini-section branch January 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants