Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameList: Convert file extensions to lowercase #10368

Merged
merged 3 commits into from Jan 17, 2022

Conversation

Pokechu22
Copy link
Contributor

This means that dol/elf files with upercase extensions (e.g. BOOT.DOL) are properly detected. ISO files with uppercase extensions already worked. This affected Rick Dangerous Wii (though it is still broken in other ways).

Note that the same case conversion is performed by Boot.cpp:

std::string folder_path;
std::string extension;
SplitPath(paths.front(), &folder_path, nullptr, &extension);
std::transform(extension.begin(), extension.end(), extension.begin(), ::tolower);

Source/Core/UICommon/GameFile.cpp Outdated Show resolved Hide resolved
This means that dol/elf files with upercase extensions (e.g. BOOT.DOL) are properly detected.
@leoetlino leoetlino merged commit b7e55e2 into dolphin-emu:master Jan 17, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants