CMakeLists: Change DiscIO dependency from common to core #10372
Conversation
DiscIO depends on some IOS functions and other functions, which are in Core and not Common. This results in link errors if using DiscIO on its own (which is why DolphinTool had a listed dependency on videocommon; videocommon has a dependency on core so adding that made things build).
| @@ -66,7 +66,7 @@ add_library(discio | |||
|
|
|||
| target_link_libraries(discio | |||
| PUBLIC | |||
| common | |||
| core | |||
There was a problem hiding this comment.
core depends on common already, so it's redundant. But there doesn't seem to be any problem with keeping it either.
There was a problem hiding this comment.
Yeah, I just figured there could be a point in avoiding implicit dependencies. But I don't know what our typical stance is on this in CMake.
There was a problem hiding this comment.
DolphinQt only specifies core and not common so I think implicit/transitive dependencies are fine.
There was a problem hiding this comment.
Yeah, seems consistent with the other targets and core will always depend on common. That said, I think our policy should be to avoid transitive dependencies in general (e.g. if both core and discio use fmt then they should both depend on the fmt target explicitly -- discio should not be relying on core to depend on fmt::fmt). core/common would be an exception to the rule.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
DiscIO depends on some IOS functions and other functions, which are in Core and not Common. This results in link errors if using DiscIO on its own (which is why DolphinTool had a listed dependency on videocommon; videocommon has a dependency on core so adding that made things build).