Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msvc/arm64: fix shadowed variable warning #10385

Merged
merged 2 commits into from Jan 27, 2022
Merged

msvc/arm64: fix shadowed variable warning #10385

merged 2 commits into from Jan 27, 2022

Conversation

shuffle2
Copy link
Contributor

No description provided.

BhaaLseN
BhaaLseN approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an oversight from #9815. One location was fixed, the other was not.

@JosJuice
Copy link
Member

The fpr.Unlock(V1Q); on line 121 is redundant now and should probably be removed. But LGTM other than that.

@shuffle2
Copy link
Contributor Author

this is a buildfix so it would be nice to merge sooner than later.

@JosJuice JosJuice merged commit 90f7565 into dolphin-emu:master Jan 27, 2022
10 checks passed
@shuffle2 shuffle2 deleted the arm-buildfix branch March 18, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@shuffle2 @JosJuice @BhaaLseN