Port memory card size override setting to new config system. #10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This setting should go in SessionSettings rather than MainSettings, as we don't ever under any circumstances want this handled globally. Otherwise, LGTM. |
AdmiralCurtiss
force-pushed
the
memcard-size-setting
branch
from
407aefb
to
5f3012b
Compare
This comment has been minimized.
This comment has been minimized.
|
This setting is used in game INIs that we ship. I thought the Session system didn't actually allow loading from game INIs? |
AdmiralCurtiss
force-pushed
the
memcard-size-setting
branch
from
5f3012b
to
407aefb
Compare
|
You seem to be correct. Reverting to Main then... |
JosJuice
approved these changes
Jan 29, 2022
|
I think in the future we probably want a way to designate a setting as 'use when loaded from GameINI but ignore when in global config', but I think this setting is fairly harmless to potentially load globally in the meantime -- there isn't a GUI setting for it so you'd have to manually write it into your global settings INI and then be surprised about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Found this straggler that was in neither config system!