Android: Get rid of __cplusplus macro checks #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files cannot compile correctly as C, so there's no reason to have ifdefs for C compatibility. We switched to not checking the __cplusplus macro in our JNI code some time ago, but it seems like I forgot to remove it from these two files.
JosJuice
force-pushed
the
android-no-cplusplus-checks
branch
from
951e2a2
to
b8a6fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These files cannot compile correctly as C, so there's no reason to have ifdefs for C compatibility.
We switched to not checking the __cplusplus macro in our JNI code some time ago, but it seems like I forgot to remove it from these two files.