UpdaterCommon: Copy content file to a temporary file before renaming on macOS #10419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
mac-updater-rename
branch
from
ad732bc
to
90665fb
Compare
JosJuice
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the auto updater that wasn't noticed until now.
On macOS, we rename files instead of copying them to avoid a quirk in the kernel's code signature cache (#9858).
#10297 added two files:
RPBJ01r1.iniandRPBJ01r2.ini. These both have the same hash, so they have the same content file name. This caused the updater to break when updatingRPBJ01r2.ini, as the content file forRPBJ01r1.iniwould be moved into the new path, making it impossible forRPBJ01r2.inito be updated as the content file would no longer exist.To fix this, we copy the content file to a temporary file and then move the temporary file to the target path.
Unfortunately, builds after #9858 will not be able to update to builds after #10297. They will need to do this manually.