New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game INI update for Tron Evolution Battle Grids (all editions) #10420
Game INI update for Tron Evolution Battle Grids (all editions) #10420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the formatting for the name, looks fine to me.
Data/Sys/GameSettings/STR.ini
Outdated
| # STRE4Q - Tron: Evolution - Battle Grids (NTSC-U) | ||
| # STRP4Q - Tron: Evolution - Battle Grids (PAL) | ||
| # STRX4Q - Tron: Evolution - Battle Grids Championship Edition (NTSC-U) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to
STRE4Q, STRP4Q, STRX4Q - Tron Evolution - Battle Grids
This is more in-line with how we format GameINIs, I'm not on my computer, but you can check other 3 letter INIs to see how it is normally handled. I know that one of these are a slightly different name, I think there's a Shawn White game or something with a similar edition, not sure how we handle that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, "Shaun White Snowboarding: Road Trip" has a different code (the last letter is different) between the normal and Target Limited Edition so it has a different entry for both entries. For this game I've combined everything as you suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine. If we add 6 letter INI, we can put the full name for Championship Edition when it comes.
62b3afc
to
d4dcc25
Compare
|
One last thing is that there's no new-line at the end of the file. Not sure how important that is, but the review thing complained. |
|
Cool, added the newline |
|
Please squash the two commits into one. Looks good to merge after that. |
|
You need to squash the changes into one commit, then I can merge. |
3d011af
to
0ffb077
Compare
|
Squashed, sorry, forgot to do that after adding the newline. |
|
@dolphin-emu-bot rebuild |
Automatically set Texture Cache Accuracy to safe in game INI as per wiki entry:
https://wiki.dolphin-emu.org/index.php?title=Tron:_Evolution_-_Battle_Grids