Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game INI update for Tron Evolution Battle Grids (all editions) #10420

Merged

Conversation

gordonfreeman01
Copy link
Contributor

Automatically set Texture Cache Accuracy to safe in game INI as per wiki entry:
https://wiki.dolphin-emu.org/index.php?title=Tron:_Evolution_-_Battle_Grids

Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the formatting for the name, looks fine to me.

# STRE4Q - Tron: Evolution - Battle Grids (NTSC-U)
# STRP4Q - Tron: Evolution - Battle Grids (PAL)
# STRX4Q - Tron: Evolution - Battle Grids Championship Edition (NTSC-U)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to

STRE4Q, STRP4Q, STRX4Q - Tron Evolution - Battle Grids

This is more in-line with how we format GameINIs, I'm not on my computer, but you can check other 3 letter INIs to see how it is normally handled. I know that one of these are a slightly different name, I think there's a Shawn White game or something with a similar edition, not sure how we handle that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, "Shaun White Snowboarding: Road Trip" has a different code (the last letter is different) between the normal and Target Limited Edition so it has a different entry for both entries. For this game I've combined everything as you suggested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine. If we add 6 letter INI, we can put the full name for Championship Edition when it comes.

@gordonfreeman01 gordonfreeman01 force-pushed the features/gamedbupdate_tron_evolution branch from 62b3afc to d4dcc25 Compare January 30, 2022 22:13
@JMC47
Copy link
Contributor

JMC47 commented Jan 30, 2022

One last thing is that there's no new-line at the end of the file. Not sure how important that is, but the review thing complained.

@gordonfreeman01
Copy link
Contributor Author

Cool, added the newline

@JosJuice
Copy link
Member

Please squash the two commits into one. Looks good to merge after that.

@JMC47
Copy link
Contributor

JMC47 commented Jan 30, 2022

You need to squash the changes into one commit, then I can merge.

@gordonfreeman01 gordonfreeman01 force-pushed the features/gamedbupdate_tron_evolution branch from 3d011af to 0ffb077 Compare January 30, 2022 22:18
@gordonfreeman01
Copy link
Contributor Author

Squashed, sorry, forgot to do that after adding the newline.

@JMC47
Copy link
Contributor

JMC47 commented Jan 30, 2022

@dolphin-emu-bot rebuild

@JMC47 JMC47 merged commit 86f83de into dolphin-emu:master Jan 30, 2022
10 checks passed
@gordonfreeman01 gordonfreeman01 deleted the features/gamedbupdate_tron_evolution branch January 30, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants