Fix improperly exclusive radio buttons #10423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QRadioButton
has anautoExclusive
function, but it only works if the buttons share the same parent widget.QButtonGroup
can be used to manually specify groups.Example of the problem
Open the breakpoints tab by selecting View → Breakpoints (the debugging UI may need to be enabled). Then, while a game is running, select "New". Then, click on the "Memory breakpoint" button 4 times. Weird stuff happens.
I'm not 100% sure that this doesn't leak memory; the documentation isn't explicit about what owns the
QButtonGroup
object (to my understanding, Qt normally manages deletion of objects, but I don't know if it'll follow theaddButton
chain backwards). We already use it this way inCheatSearchFactoryWidget.cpp
though.