BlendingState: Set source and destination alpha factors in logic op workaround #10441
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
improved-logic-op-workaround
branch
from
467afe7
to
bdc55f9
Compare
OatmealDome
changed the title
|
Thanks for building this! I've been affected by this exact bug on my Intel Mac and my Pixel 3a (android build) using the Vulkan video backend. I tested the android apk from your CI build, and Kirby's Air Ride looks perfect now on my Pixel 3a I tried testing the "osx-universal" dmg from your CI build on my mac, but it's crashing when I try to open any game, probably something unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Title. Kirby's Air Ride uses the alpha value as a multiplier for the pixel's color in shadow rendering. If we don't update it, then the alpha ends up being set to 0 for the entire frame, causing the entire world to be shadowed in darkness as every color gets multiplied by zero.
The FifoCI diff can be found here. Doesn't seem to affect any other games.
Fixes Kirby's Air Ride on Intel Macs.