OGLMain: Set default value for bSupportsSettingObjectNames #10444
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
I remember thinking that I saw it not being initialized in OGLMain when I reviewed #10422 (similar to how I caught it not being initialized in D3D12), but then I convinced myself that it was getting initialized. Looking at it again, it's not, so I'm not sure what I saw (maybe I spotted the initialization in NullBackend or SWmain and thought that was being applied to OGL?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was able to reproduce the OpenGL crash from 12836, but only when starting Dolphin with Vulkan set, switching to OpenGL, and starting a game. I think this might be because the value from Vulkan carries over to OpenGL and doesn't get overwritten?
I tested my reproduction steps 5 times and it hasn't crashed yet, so I believe this fixes the issue.