Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JitRegister: Use fmt #10456

Merged
merged 1 commit into from Feb 16, 2022
Merged

JitRegister: Use fmt #10456

merged 1 commit into from Feb 16, 2022
+22 −24

Conversation

merryhime
Copy link
Contributor

Prefer fmt to printf-style formatting.

Pokechu22
Pokechu22 reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@Pokechu22 Pokechu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. I have some minor suggestions to enable fmt's compile-time checking, but the changes otherwise look good.

Source/Core/Common/JitRegister.h Outdated Show resolved Hide resolved
Source/Core/Common/JitRegister.h Outdated Show resolved Hide resolved
Source/Core/Common/JitRegister.h Outdated Show resolved Hide resolved
@merryhime
Copy link
Contributor Author

Sounds resonable to me. Updated.

@Pokechu22
Copy link
Contributor

Looks good, but can you squash the two commits together?

@merryhime
JitRegister: Use fmt
be81fe8 
Prefer fmt to printf-style formatting.
@JosJuice JosJuice merged commit d9e0bf7 into dolphin-emu:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokechu22 Pokechu22 Pokechu22 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@merryhime @Pokechu22 @JosJuice