Use config changed callback to detect SD insertion/ejection #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves the GUI from having to manually call SDIO_EventNotify. With that out of the way, we can let users change the "Insert SD Card" setting on Android while a game is running.
JosJuice
force-pushed
the
sd-card-callback
branch
from
52d44e9
to
90c576e
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
| if (m_sd_card_inserted != Config::Get(Config::MAIN_WII_SD_CARD)) | ||
| { | ||
| Core::RunAsCPUThread([this] { | ||
| const bool sd_card_inserted = Config::Get(Config::MAIN_WII_SD_CARD); |
There was a problem hiding this comment.
Should this have a Core::IsRunning() check, just in case?
There was a problem hiding this comment.
My thinking was that the destructor of this class will deregister the callback when emulation ends. Or would that not work as intended?
There was a problem hiding this comment.
My thinking was that there might be some multithreading shenanigans where one thread was in the process of shutting down while another was calling RefreshConfig(), but thinking about it in that case we'd have worse problems anyway by writing to an already destructed instance. So... probably fine, then.
|
Other than that, seems like an improvement to me. |
AdmiralCurtiss
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This saves the GUI from having to manually call SDIO_EventNotify. With that out of the way, we can let users change the "Insert SD Card" setting on Android while a game is running.