FramebufferManager: Flush pending EFB pokes in PopulateEFBCache #10471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. flush pokes before running an EFB peek, if the cache tile isn't present. If the cache tile is present, then EFB pokes should have been written to the cache tile and thus don't need to be flushed.
Pokechu22
force-pushed
the
flush-efb-pokes-before-peeking
branch
from
688a2e8
to
23cbd57
Compare
iwubcode
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I.e. flush EFB pokes before running an EFB peek, if the cache tile isn't present. If the cache tile is present, then EFB pokes should have been written to the cache tile and thus don't need to be flushed.
Found while working on dolphin-emu/hwtests#44 (permalink to the relevant version). As part of that test, I send a bunch of EFB pokes, and then to make sure I wrote the EFB correctly, I use EFB peeks immediately afterwards to verify those values. That was giving incorrect results in Dolphin (Test 1 was failing) but now gives correct results. (This PR does not fix the other issues covered by that hardware test; tests other than 1 and 2 still fail with this PR.)