Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual update check which was hardcoded to "dev" track #10473

Merged
merged 1 commit into from Mar 1, 2022

Conversation

delroth
Copy link
Member

@delroth delroth commented Feb 23, 2022

@OatmealDome
Copy link
Member

I tried fixing this previously in #9893, but apparently it is intentional behaviour.

@delroth
Copy link
Member Author

delroth commented Feb 23, 2022

I'm going to assume that the original decision was not made strongly. We now have the hindsight with us showing that users are confused enough by this behavior to file bug reports about it.

I think the proper fix would be something along the lines of "no update on your track, but if you switched to that other track there would be an update available". That's not completely trivial to implement, and this is a niche feature, so I think going for the less confusing "follow the selected track" option is probably better.

@spycrab any objection? You wrote this originally.

@delroth
Copy link
Member Author

delroth commented Mar 1, 2022

Merging this for now, please feel free to send a revert if you feel strongly otherwise and want to discuss it further!

@delroth delroth merged commit 8ecfa53 into dolphin-emu:master Mar 1, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants